agent: reject config with invalid options #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| Result: &result, | ||
| Metadata: &md, | ||
| Result: &result, | ||
| ErrorUnused: true, |
There was a problem hiding this comment.
We should leave this false and remove all the unused fields from Config. Instead use the Unused field in Metadata. We can scan that for fields that are not (services, checks, service, check) and error / warn on those. This way we have more fine grain control later when we deprecate flags and stuff too.
There was a problem hiding this comment.
Yeah that seems less ghetto - I'll fix this up.
|
Fixed in 42ace3a. |
ryanuber
added a commit
that referenced
this pull request
Jan 5, 2015
agent: reject config with invalid options
Closed
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps by rejecting configurations with invalid keys. Mapstructure supports this already, but the way we parse services and checks doesn't use straight mapstructure decoding, so there are a few discarded fields in the config struct. AFAIK there wasn't a better way to allow this.
/cc @armon @mitchellh